Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some changes #223

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Revert some changes #223

merged 1 commit into from
Jun 23, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Jun 20, 2022

PULL REQUEST

Overview

We inadvertently made some changes which break the logic of some unit tests. I'm reverting those changes here, adding some context and adding some other clean-ups.

The original PR mentions lint issues. If the changes reverted here were fixes for linting issues then we should fix the linting setup in Makefile because I'm not getting any warnings/errors.

Example for Visual Changes

Checklist

  • All git commits are signed. (REQUIRED)
  • All new methods or updated methods have clear docstrings.
  • Testing added or updated for new methods.
  • Verified if any changes impact the WebPortal Health Checks.
  • Appropriate documentation updated.
  • Changelog file created.

Issues Closed

@ro-tex ro-tex self-assigned this Jun 20, 2022
Makefile Show resolved Hide resolved
api/handlers_test.go Show resolved Hide resolved
@ro-tex ro-tex marked this pull request as ready for review June 20, 2022 14:59
@ro-tex ro-tex enabled auto-merge June 20, 2022 15:00
@ro-tex ro-tex merged commit 3b240ee into main Jun 23, 2022
@ro-tex ro-tex deleted the ivo/correction branch June 23, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants